search

colineckert / obsidian-things

An Obsidian theme inspired by the beautifully-designed app, Things.
MIT License
721 stars 62 forks source link

Font family override is not respected #91

Closed ttax00 closed 2 years ago

ttax00 commented 2 years ago

Even though this is similar an issue to #82 , I believe it might be a bug.

The override will only work for --font-editor-override and not for --font-text-override even when it is set to a different font. (Interface font and Text font respectively in the setting)

Which means the Text font is not respected. even when Interface font is unset.

body {
    --font-editor: var(--font-editor-override), var(--font-text-override), var(--font-editor-theme);
}

image UPDATE: Apparently view mode works, but editor + live-preview mode still uses the default font instead of override.

colineckert commented 2 years ago

Hey this should now be fixed in Things v2 and Obsidian 1.0. Can you confirm? Thanks!

ttax00 commented 2 years ago

Hey this should now be fixed in Things v2 and Obsidian 1.0. Can you confirm? Thanks!

I've updated to Things v2, and the font-overriding issue still stands in editor mode. Live preview and Reading view works as expected. It required a reload when updating theme. Checked to be working now, thank you so much!!

ttax00 commented 2 years ago

Issue resolved.