colinhemphill / nextjs-resume

A Next.js résumé for developers
https://nextjs-resume.netlify.app/
MIT License
178 stars 43 forks source link

changing accentColor does not change dark/light mode #206

Closed justin-hackin closed 1 year ago

justin-hackin commented 1 year ago

I want my PDF to be light so it's printable (I would suggest this be the default, and that the config for PDF and web be separate). I can't seem to change the theme universally though.

In the readme, it's stated:

accentColor: string. The name of an accent palette from Radix UI Colors. If using a standard color, the contrasting text color will be white, and if using a bright color, the contrasting text color will be black.

However, when changing the accent color to one of the "bright" colors e.g. "sky", the background does not become light. When the neutral color is changed to grey the mode does change to light background, but the lack of contrast makes some of the text invisible, and most of it nearly unreadable.

In the chart you show each accent color could be dark or light but above it's stated accent color determines light/dark mode.

justin-hackin commented 1 year ago

I misunderstood this quote to mean the dark mode was determined by accent color. Instead, the text spoken of is only that which is inside the accent color and the theme is determined by prefers-color-scheme. I swore I turned off my Night Eye dark mode plugin but as it turns out, that was the cause of the unreadable text 🤦🏻