search

colinkeenan / silentcast

Create silent mkv screencast and animated gif.
GNU General Public License v3.0
512 stars 22 forks source link

Changes how xrandr variables are retrieved. #16

Closed voor closed 8 years ago

voor commented 8 years ago

Apologizes for bash beautification, Atom tends to love doing that. This was mentioned in #15 but it doesn't resolve that issue as turns out to be unrelated.

colinkeenan commented 8 years ago

Sorry I have not had any time in the past 7 months or so, and still don't. I need to know what this does. I got the xrandr variables originally from some answer I found somewhere and probably tweaked them with trial and error. That's pretty much how I wrote the whole application. What problem does your new shorter method solve? I don't really know anything about head and very little about awk. I worry that your solution may bring back some problem I already fixed by tweaking.

voor commented 8 years ago

If you have two monitors you'd have multiple lines returned in the way you're previously doing it. This handles that situation by utilizing the first output of xrandr that just outputs your current max resolution for you.

colinkeenan commented 8 years ago

Thanks. This is better.