search

colinl / node-red-contrib-pid

A node-red PID loop controller node intended for the control of real world processes
Apache License 2.0
26 stars 17 forks source link

ReferenceError: ts is not defined #2

Closed nerobot closed 7 years ago

nerobot commented 7 years ago

Hi,

I've just started using the "derivative smoothing factor" and I'm now coming up with the following error;

ReferenceError: ts is not defined

I never had this issue when not using the derivative smoothing factor.

I believe var is missing from line 108 in pid.js. Adding this to my local version appears to remove this issue for me.

Thanks,

Steven

colinl commented 7 years ago

Yes, you are right, I wonder why I did not get that previously. I did most of my testing with the code in a function node, maybe the parser is more strict when it is built as a node. Thanks again.

colinl commented 7 years ago

Fixed by commit 7c7c88a0c69c50ab6f60f1d57391b51dadbc30b7 Released in version 1.1.0