search

colinmarc / impala-ruby

an impala client for ruby
MIT License
34 stars 22 forks source link

Allow invalidate metadata command #6

Closed beeandbo closed 11 years ago

beeandbo commented 11 years ago

Added invalidate to the list of known commands so you can issue an invalidate metadata query.

colinmarc commented 11 years ago

Mind adding a test or two?

Thanks!

beeandbo commented 11 years ago

Yep, no problem. I'll add something next week.

On Fri, Oct 11, 2013 at 5:27 PM, Colin Marc notifications@github.comwrote:

Mind adding a test or two?

Thanks!

— Reply to this email directly or view it on GitHubhttps://github.com/colinmarc/impala-ruby/pull/6#issuecomment-26185312 .

beeandbo commented 11 years ago

Tests are added.

As a random note, I was unable to run the tests out of the box because the thrift gem requires thrift, but does not mark it as a dependency in the gemspec. I don't think this is your issue (https://issues.apache.org/jira/browse/THRIFT-2145), but just wanted to mention it as it caused some friction during testing.

colinmarc commented 11 years ago

Yeah, I know, but I don't want to cave and add thin/rack as dependencies to impala-ruby, so I'm not sure what to do.

Thanks so much!