colinmeinke / ghost-storage-adapter-s3

An AWS S3 storage adapter for Ghost
Other
186 stars 87 forks source link

Region set to 'us-east-1' via Environment Variables does not work #21

Closed techwes closed 7 years ago

techwes commented 7 years ago

https://github.com/colinmeinke/ghost-storage-adapter-s3/blob/3c98506ab3ff77152cf8b92d423b97d0f3e576ff/src/index.js#L34

The last part of the || should be `https://s3${this.region === 'us-east-1' ? '' : `-${this.region}`}.amazonaws.com/${this.bucket}` instead.

I can submit a pull request to fix this or someone already set up to contribute and just make this simple change

colinmeinke commented 7 years ago

Yes please, PR away!