colinmollenhour / Cm_Cache_Backend_Redis

A Zend_Cache backend for Redis with full support for tags (works great with Magento)
Other
387 stars 142 forks source link

Sentinel persistent #120

Closed Xon closed 7 years ago

Xon commented 7 years ago

On-going usability improvements to sentinels and slaves.

Xon commented 7 years ago

@colinmollenhour I'm still fiddling with how to present extra sentinel/slave options in a way which isn't confusing but allows the code to be as consistent as possible with how options for sentinel/slave/master are presented.

Xon commented 7 years ago

@colinmollenhour do you have any feedback on this change?

I haven't had any issues so far with it.

colinmollenhour commented 7 years ago

I have tested it briefly and it worked fine. I think this is about ready to merge into master. Any last requests? :) Thanks for the help, btw!

Xon commented 7 years ago

Nope, nothing related to this PR.