search

colinmollenhour / Cm_Cache_Backend_Redis

A Zend_Cache backend for Redis with full support for tags (works great with Magento)
Other
390 stars 142 forks source link

Remove all dependancies #144

Closed woutersamaey closed 4 years ago

woutersamaey commented 4 years ago

Why does this repo depend on magento-hackathon/magento-composer-installer?

I have been using this class for many years in simple Zend Framework projects, outside of Magento.

At first glance, this repo does not appear to have anything Magento related, so it should just work standalone or simply depend on zf1/zend-cache

colinmollenhour commented 4 years ago

Totally agreed.. I'm not a composer expert so I'm not sure what repercussions there would be for Magento users for removing it.. Maybe none?

boldhedgehog commented 4 years ago

magento-hackathon/magento-composer-installer was required for Magento 1, Magento 2 has it in some other composer.json, you can remove it from here.

colinmollenhour commented 4 years ago

I don't want to drop support for M1, but is it really "required" or should it perhaps just be "suggested"? An M1 project is going to already have magento-hackathon/magento-composer-installer as a dependency already, right?

boldhedgehog commented 4 years ago

I think making it suggested is fine. I also think that Magento projects installing this package with Composer should have magento-hackathon/magento-composer-installer dependency alongside other packages installed with Composer.

UPD: Example https://github.com/OpenMage/magento-lts/blob/1.9.4.x/composer.json

colinmollenhour commented 4 years ago

Please see cecd07a. Looks good?

colinmollenhour commented 4 years ago

Also updated readme with mention of composer install.