search

colinmollenhour / Cm_RedisSession

Redis-based session handler for Magento with optimistic locking
208 stars 121 forks source link

GitHub 129 replace submodules with composer #130

Closed kirkmadera closed 6 years ago

kirkmadera commented 7 years ago

There is no clean way to handle this... The magento-composer-installer plugin loads the Composer autoloader after the Magento autoloader so "lib/Credis" will always win over "vendor/colinmollenhour/credis". I think the cleanest solution is to suggest removing "lib/Credis" from core code. I added this to the README.

Ideally, I think the magento-composer-installer should load the Composer autoloader before the M1 autoloader, but that seems very unlikely to change since it's so widely used now and M1 is on its way to being replaced by M2.

This would be a breaking change for modman installations and would probably have to go into a 2.0.0

colinmollenhour commented 7 years ago

Why is it necessary to remove the git submodules? As I understand it those are ignored by composer anyway. If removed then the modman installation would be broken and I don't think I want to break that.

kirkmadera commented 7 years ago

That's true. The submodules could actually stay in place to continue to support modman installations. They are not in the way of a composer driven installation.

kirkmadera commented 7 years ago

Added the submodules back in. This one ties in with #127 though and might need some manual merging. I can make a PR with both ideas combine also if that's easier