colinmollenhour / Cm_RedisSession

Redis-based session handler for Magento with optimistic locking
208 stars 121 forks source link

Compression is not disabled when compression_threshold is set to 0 #133

Closed nemphys closed 6 years ago

nemphys commented 6 years ago

The way the session's private compression threshold variable is set ($this->_compressionThreshold = $this->config->getCompressionThreshold() ?: self::DEFAULT_COMPRESSION_THRESHOLD;) makes it take the default (2048) value if set to 0 in the xml.

Just noticed this while debugging something irrelevant (and all this time I thought I had compression disable :-) ).

Quazz commented 6 years ago

I think you need to set compression_lib to none in order to disable compression.