search

colinmollenhour / Cm_RedisSession

Redis-based session handler for Magento with optimistic locking
208 stars 121 forks source link

PHP 7.2 Compatability #154

Closed scottcdi closed 3 years ago

scottcdi commented 6 years ago

Magento just recently announced that they will be openly supporting PHP 7.2 for the magento 1 instance and have also recently just released a patch.

Does anyone know if this plugin will be compatible with PHP 7.2 or if a patch is planning on being developed here as well?

colinmollenhour commented 6 years ago

AFAIK there are no reasons this shouldn't work in PHP 7.2 as it is. An older version of this extension is included in Magento 1 already so it has probably already undergone some testing but I haven't looked at the patch yet to see if it included changes to this extension.

scottcdi commented 6 years ago

The patch they released is basically just a clone of the inchoo PHP 7 compatibility module. Has anyone reported any issues with the inchoo plugin and redis to your knowledge?

joshua-bn commented 3 years ago

@scottcdi if you're still using M1, you should probably switch to OpenMage. If you are on OpenMage, this will work fine. I am running on PHP 7.4.