search

colinmollenhour / Cm_RedisSession

Redis-based session handler for Magento with optimistic locking
208 stars 121 forks source link

Sync XML module version #186

Closed loekvangool closed 2 years ago

fballiano commented 2 years ago

I think this should be merged

colinmollenhour commented 2 years ago

Why does the xml module version matter if there are no database migrations? It seem sit would just create busy-work when updating packages?

loekvangool commented 2 years ago

Makes it easier to match latest and installed versions.

colinmollenhour commented 2 years ago

I think composer is a much better tool for this purpose though?

loekvangool commented 2 years ago

The bulk of Magento modules that I use don't support composer, hence I don't use it for managing modules atm. I use Firegento to get a list of installed modules and their versions and I compare to the latest available versions to start my upgrade process.

colinmollenhour commented 2 years ago

I appreciate that different people have different methods and I try to accommodate them but in this case I must decline. In my opinion the version number of a library release belongs outside of the source code, changing version numbers for every point release (basically every PR for this project) is just unnecessary hassle. The Magento module version number is very useful for the database migrations and may have been worthwhile in the days of Magento Connect but that is no more and Github releases + Packagist ++ Composer is a solid system that I highly recommend adopting (and this is coming from the author of modman 😄 ).