search

colinmollenhour / Cm_RedisSession

Redis-based session handler for Magento with optimistic locking
208 stars 121 forks source link

Compatibility with latest versions of openmage #187

Closed fballiano closed 2 years ago

fballiano commented 2 years ago

In https://github.com/OpenMage/magento-lts/pull/2138 we're trying to use this repo instead of the builtin version of Cm_RedisSession but it doesn't work because of https://github.com/OpenMage/magento-lts/pull/1513

This PR should fix.

Probably it should be tagged as 3.0?

justinbeaty commented 2 years ago

Thanks @fballiano for making the PR.

I did not test it yet since I think it's just a PHPStan error we are fixing, but I think it should work.

The removing of submodules is because for our use-case we're installing via composer. I know at least the submodule in lib should be okay, but I think code/local/Credis isn't needed with composer either.

justinbeaty commented 2 years ago

That was merged fast =)

I guess @fballiano you can pull it into magento-lts and see if phpstan complains anymore