Allow docker swarm resolve container ip

colinmollenhour / mariadb-galera-swarm

MariaDb Galera Cluster container based on official mariadb image which can auto-bootstrap and recover cluster state.

https://hub.docker.com/r/colinmollenhour/mariadb-galera-swarm

Apache License 2.0

223 stars 102 forks source link

Allow docker swarm resolve container ip #82

Closed olafbuitelaar closed 4 years ago

olafbuitelaar commented 5 years ago

I've cherry picked the relevant changes of #79 added an extra environment variable ($IP_RESOLVEMETH = "swarm_tasks") in case you want to resolve the containers via tasks.

colinmollenhour commented 5 years ago

According to @alphaDev23 using "tasks." to prefix the nodes resolves the issue for Docker Swarm Mode. (link)

I updated the docs in https://github.com/colinmollenhour/mariadb-galera-swarm/commit/3723c2a784d105d9ea84e5118d13414174a0f26b accordingly. Keeping in mind GCOMM_MINIMUM is already a user-definable variable, can you explain why this PR is necessary, if you still believe it is? I just don't want to introduce additional complexity if it is not necessary. Thanks!

olafbuitelaar commented 5 years ago

it indeed seems to work now, i've had tested this before. Hence i made this PR. You can either close it, or consider it a convenient setup option, which overlays the tasks. part.

colinmollenhour commented 4 years ago

Another PR was merged which overlaps in functionality with this PR.