search

colinmollenhour / mongodb-php-odm

A simple but powerful set of wrappers for using MongoDb in PHP (also a Kohana 3 module)
BSD 3-Clause "New" or "Revised" License
208 stars 50 forks source link

Style cleanup #24

Closed kohenkatz closed 11 years ago

kohenkatz commented 12 years ago

This is a cleanup to meet Kohana's Coding Style guidelines, as checked with https://github.com/kohana/coding-standards and PHP_CodeSniffer.

This is part 1 of the cleanup, which fixes the guidelines related to whitespace, parens, braces, and AND/OR. This pull request resolves around 280 PHP CodeSniffer errors.

I ran PHP CodeSniffer using:

phpcs --report=checkstyle --report-file=~/kohenkatz-mongodb-php-odm.log.xml --standard=Kohana ~/projects/github/kohenkatz/mongodb-php-odm/
kohenkatz commented 12 years ago

Part 2 (which will probably be a separate pull request) will include changing function and variable names to satisfy Kohana's "Lowercase with underscores" requirement. Because it is an API change, it is separate.

colinmollenhour commented 12 years ago

I appreciate the efforts but I'm not interested in anything breaking backwards compatibility purely to satisfy kohana since this library is used outside of kohana as well. Many of the function names were kept to be consistent with the official mongo driver.

Sent from my Android phone with K-9 Mail. Please excuse my brevity.

kohenkatz commented 12 years ago

@colinmollenhour I understand that, so I won't submit the second pull request. This request, however, is purely cosmetic, with no breaking changes.