update_safe accepts $upsert and $multi options

[colinmollenhour]

Actually, looking back at this I don't get the motivation for this patch.. update_safe already allows for overriding these options:

$collection->update_safe($criteria, $update, array('multiple' => TRUE, 'upsert' => TRUE));

So now there are two ways to override multiple and upsert so I think this should be reverted..

[sergeyklay]

yep, but presently update_safe is:

public function update_safe ($criteria, $update, $options = array(), $upsert = false, $multi = false)
{
   ...
}

in my opinion $upsert and $multi not needed here.

Actually, if you look at the php-prototype of update method, we can see the following: public bool|array MongoCollection::update ( array $criteria , array $new_object [, array $options = array() ] ).

In his turn MongoDB defines this method as follows: db.collection.update(query, update[, options])

By this, I don't see the point of invent additional arguments for update_safe.

See please:

• http://www.php.net/manual/en/mongocollection.update.php
• http://docs.mongodb.org/manual/reference/method/db.collection.update/

Also for a better understanding, I suggest to rename $update to $new_object

[panrafal]

From my pov it's more convenient to have the most used parameters available right on the function - especially if you use any kind of code completion. But I understand yours, especially the part with original mongo api :)

[colinmollenhour]

@panrafal If it weren't for the redundancy which causes ambiguity then I'd agree with you. Reverted.