search

colinmollenhour / mongodb-php-odm

A simple but powerful set of wrappers for using MongoDb in PHP (also a Kohana 3 module)
BSD 3-Clause "New" or "Revised" License
208 stars 50 forks source link

Go ahead #63

Closed sergeyklay closed 1 year ago

sergeyklay commented 10 years ago
  1. It seems it is time to use PHP 5.4 :) Short syntax, traits, etc.
  2. What do you think about the PSR as a whole?
colinmollenhour commented 10 years ago

I think file names should be changed to have first character upper-case to work better with autoloaders. However, I don't really want to break backwards compatibility beyond that. I agree that a PHP 5.4 or 5.5 version could be much nicer (Generators, ftw!) but I think it might be better to start a fork for these kinds of major changes.

sergeyklay commented 10 years ago

Hm, why fork? You might create a separated branch for all of these changes.

colinmollenhour commented 10 years ago

I don't mean a separate github repo necessarily, just that the new version would not replace the old version on master. However, I personally do not have time to work on such a project so rather than submitting pull requests to me you may just prefer to actually create your own fork and be the maintainer of the new version and I will be the maintainer of the old version.

sergeyklay commented 10 years ago

Okay, I will maintain new branch on my repo. I need to know, if I will do PR from this new branch will you accept these requests to new branch in your own repo?

colinmollenhour commented 10 years ago

I just don't want to cause trouble for people who have cloned master and do a git pull and it breaks all of their code.. Otherwise I am open to any way you want to go about it.