Fix deadlock when using `session_start(array("read_and_close"=>true))`

colinmollenhour / php-redis-session-abstract

A Redis-backed PHP session handler with optimistic locking

Other

59 stars 47 forks source link

Fix deadlock when using `session_start(array("read_and_close"=>true))` #17

Open huguesalary opened 7 years ago

huguesalary commented 7 years ago

This might not be the best.

The weird thing is that close() doesn't provide the session_id() which we need to release the lock.

This makes me think this isn't the right place to release the lock, and read() should probably make sure it releases the lock when it's called with "read_and_close".