search

colinmorris / atypicality

19 stars 1 forks source link

Tweak layout of spotify players #27

Open colinmorris opened 6 years ago

colinmorris commented 6 years ago

They should be positioned directly beneath the previous card.

(Possibly inside the previous card, or in cards of their own, though on some mobile devices, the fixed 300px width of the players is greater than the current width of the cards)

peterwgnd commented 6 years ago

Had been thinking the same. I think I can adjust that width and still have it render correctly. I’ll see if I can’t slot it in. Wish they made a smaller player

On Mar 3, 2018, at 4:44 PM, Colin notifications@github.com wrote:

They should be positioned directly beneath the previous card.

(Possibly inside the previous card, or in cards of their own, though on some mobile devices, the fixed 300px width of the players is greater than the current width of the cards)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

peterwgnd commented 6 years ago

Working through this now. Also wondering if maybe on desktop it would make sense to leave the player in the sticky section?

colinmorris commented 6 years ago

I'm somewhat hesitant to go that way. It seems hard to do any kind of smooth transition between players, so it ended up looking kind of jerky when switching between songs (and when adding/removing players).