search

colinoflynn / pico-python

PicoScope Python Interface
Other
101 stars 80 forks source link

Fix loading of DLLs on windows by adding a call to find_library() #167

Closed Cyclical- closed 4 years ago

Cyclical- commented 4 years ago

This change fixes the inability of windll.LoadLibrary() to locate the PicoSDK dlls by adding a call to ctypes.util.find_library(). For this to work either the installed PicoSDK bitness must be the same as the python bitness, or if both SDK versions are installed the equal bitness version must be first in the system PATH.

pep8speaks commented 4 years ago

Hello @Cyclical-! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2020-10-09 19:30:25 UTC
hmaarrfk commented 4 years ago

Thanks for the contribution.

I'm sorry to ask, but could you undo much of the formatting changes you made? I feel like you had your editor on auto format

Cyclical- commented 4 years ago

Oops, my bad. Must have happened when I ran black to format for PEP8.

Cyclical- commented 4 years ago

By the way, this should likely close issue #155

hmaarrfk commented 4 years ago

Closes #155

hmaarrfk commented 4 years ago

Thanks for going through all of them.

hmaarrfk commented 4 years ago

Version 0.7.12 should have what you need (though I might release 0.7.13 soon)