search

colinsheppard / insalmo-instream-gui

GUI for both the inSALMO and inSTREAM models
GNU General Public License v2.0
1 stars 0 forks source link

Wrong value in uncertainty param1 column of LFT raw results page #57

Closed SFRailsback closed 11 years ago

SFRailsback commented 11 years ago

As a way of avoiding issue 47, I ran LFT with one uncertainty parameter, with one value for it, with high and low ranges both set to 1.0. The only problem I noted was the value reported for the uncertainty parameter in the "Raw results" page of the LFT results spreadsheet. It reported a value of 0.5, whereas the parameter's value was 30.

colinsheppard commented 11 years ago

The uncertainty parameter values in LFT_Raw_Results are not actually parameter values, they represent a multiplier on the parameter value that is scaled from 0 to 1. So 0 represents the lower limit and 1 is the upper limit. When you only have 1 uncertainty scenario, then the difference is split and you end up with 0.5. If you unwind the scaling: (scaledValue * (upper - lower) + lower) * defaultParamValue, you'd get back 30.

The column naming is confusing, it should really read something like "fishRespParamAScaledFactor", or I could do the unwinding of the parameters when writing LFT_Raw_Results, it depends on how the data will ultimately be analyzed I suppose.