Stop the webpack watcher when the electron app is closed

colinskow / angular-electron-dream-starter

:tada: An Angular Electron Starter kit featuring Webpack, Angular 4 (Router, Http, Forms, Services, ngrx, Tests, E2E, Coverage), Karma, Spectron, Jasmine, Istanbul, and TypeScript

MIT License

163 stars 54 forks source link

Stop the webpack watcher when the electron app is closed #4

Open osechet opened 7 years ago

osechet commented 7 years ago

I'm submitting a ... [ ] bug report [x] feature request [ ] question about the decisions made in the repository
What is the current behavior? When closing the electron app, the webpack watcher remains running, forcing the dev to interrupt it.
What is the expected behavior? It would be great if the webpack watcher could stop at the same time as the electron app.
What is the motivation / use case for changing the behavior? Make life of the dev easier ;)
Please tell us about your environment: angular-electron-dream-starter's master on Ubuntu 14.04

colinskow commented 7 years ago

I agree, please let me know if you can figure out how to do this! It may require a PR to electron-connect.

Kaffiend commented 7 years ago

I've been seeing this a lot too. When you try to restart rimraf has a fit when one of the directories is in use.

Error: EPERM: operation not permitted, unlink 'B:\appl\ics\ian\nge_client\dev\node_modules\symbol-observable'
    at Error (native)

I've been reloading the editor to clear up the binding.

VSCODE: ctrl + shift + p => reload.

its annoying but it works and i dont have to touch the mouse :)

I think this is from the angular language service actually.. might be a different issue.

Kaffiend commented 7 years ago

disregard, different issue, it is the angular language service causing the rimraf on restart to complain.

Kaffiend commented 6 years ago

this could possibly be handled by adding nodemon to wrap the process, and can also be configured to restart on just electron main process changes.