search

colinskow / angular-electron-dream-starter

:tada: An Angular Electron Starter kit featuring Webpack, Angular 4 (Router, Http, Forms, Services, ngrx, Tests, E2E, Coverage), Karma, Spectron, Jasmine, Istanbul, and TypeScript
MIT License
162 stars 54 forks source link

Update to NGRX 4 #6

Closed Kaffiend closed 6 years ago

Kaffiend commented 6 years ago

Do you have plans to update to NGRX 4.x.x?

colinskow commented 6 years ago

Absolutely. Pull requests welcome. Otherwise I'll probably get to it within the 2-3 couple weeks.

Kaffiend commented 6 years ago

I'd wait till the redux dev tools and router-store stop hating each other anyway 😺

Kaffiend commented 6 years ago

Given the simple nature of the starter, there is not enough to fully flex the new features of NGRX 4.x. Do you want to keep it simple as is, or add another module to explain and demo the async state and effects?

Kaffiend commented 6 years ago

also waiting for an update for HMR from angular class here

Kaffiend commented 6 years ago

@colinskow Forking a little more advanced version of this seed. NGRX 4 and all its features from the example app with this build pipeline is the target I'm aiming for. Took a bit and wrapped my head around the HMR aspect and i think i know where the issues lie.

Kaffiend commented 6 years ago

I've got it updated and working in my work project. I can issue a PR later this weekend for updating this seed and the slightly more advanced ngrx example app fork im working on.

colinskow commented 6 years ago

OK, I definitely want to get this seed working with NGRX 4. But it cannot break HMR. I'm open to a better example app, but don't want to make it too complicated. This is simply scaffolding for users to start their own apps.

Kaffiend commented 6 years ago

I've got the HMR working as well. I wont alter the seed example just update NGRX and its new API. I'm going to fork this seed with a merged NGRX Official example and if you like you can link to it in the ReadMe or something for anyone interested.