search

colinskow / angular-electron-dream-starter

:tada: An Angular Electron Starter kit featuring Webpack, Angular 4 (Router, Http, Forms, Services, ngrx, Tests, E2E, Coverage), Karma, Spectron, Jasmine, Istanbul, and TypeScript
MIT License
162 stars 54 forks source link

Upgraded Deps and NGRX 4.x.x #7

Closed Kaffiend closed 6 years ago

Kaffiend commented 6 years ago
Kaffiend commented 6 years ago

completes #6

Kaffiend commented 6 years ago

this may resolve #5 as well...

Kaffiend commented 6 years ago

need to update the tests.

Kaffiend commented 6 years ago

fixing AOT

Kaffiend commented 6 years ago

@colinskow looks like everything else is fine, just AOT needs some love. I'll take another look at this tomorrow. unless someone else can figure it out before hand.

Kaffiend commented 6 years ago

currently ngrx-store-freeze is not compatible with v4, see here so I removed it, until it can be updated. I suspect this PR will remain open and we can update it as NGRX and dependent libs progress.

colinskow commented 6 years ago

Thank you very much! I will have a chance to review next Tues or Weds.

colinskow commented 6 years ago

How is the progress on this going? It looks like AngularClass now has a new HMR loader that works out of the box with ngrx 4.

@Kaffiend are you interested in finishing this, or should I go ahead. It looks fairly simple.

Css-IanM commented 6 years ago

I have been swamped, of late. I might be able to get to this, this weekend. Unless you can find time before then. I dont mind either way. I havent seen the new loader as i've been busy on some work projects. Ill have to check that out. This PR works with everything but AOT i think, if i recall correctly. But would need updated with the new loader it sounds like.

Derp: was still on my work account.

Kaffiend commented 6 years ago

@colinskow I looked at the HMR Loader. I don’t see anything other than my PR explaining how to hook into NGRX4 with the existing loader. Am i missing something?

Ian Mackie Lead Developer Complete System Support, Inc.

From: Css-IanM Sent: Thursday, August 31, 2017 2:39 PM To: colinskow/angular-electron-dream-starter Cc: Ian Mackie; Mention Subject: Re: [colinskow/angular-electron-dream-starter] Upgraded Deps and NGRX4.x.x (#7)

I have been swamped, of late. I might be able to get to this, this weekend. Unless you can find time before then. I dont mind either way. I havent seen the new loader as i've been busy on some work projects. Ill have to check that out. This PR works with everything but AOT i think, if i recall correctly. But would need updated with the new loader it sounds like. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

colinskow commented 6 years ago

The main issue is that the build needs to pass, including with AoT. It looks like ngrx-store-freeze is still not ready for 4.0. Perhaps we can stub the code in but comment it out until ready.

Over the next few days I'll take a look at your PR and compare it to the official migration guide to ensure everything is standard. We can merge when the build is passing.

Css-IanM commented 6 years ago

I have the AOT code on my own branch in a separate project I just need to update the PR here. I’ve also yet to update the router store with the new serializer, which was release and updated since the last PR here. There is still some yet to do.

Ian Mackie Lead Developer Complete System Support, Inc.

From: Colin Skowmailto:notifications@github.com Sent: Saturday, September 2, 2017 6:14 PM To: colinskow/angular-electron-dream-startermailto:angular-electron-dream-starter@noreply.github.com Cc: Ian Mackiemailto:ianm@completesystemsupport.com; Commentmailto:comment@noreply.github.com Subject: Re: [colinskow/angular-electron-dream-starter] Upgraded Deps and NGRX 4.x.x (#7)

The main issue is that the build needs to pass, including with AoT. It looks like ngrx-store-freeze is still not ready for 4.0. Perhaps we can stub the code in but comment it out until ready.

Over the next few days I'll take a look at your PR and compare it to the official migration guide to ensure everything is standard. We can merge when the build is passing.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/colinskow/angular-electron-dream-starter/pull/7#issuecomment-326772056, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AdUBQjJSyIFJqIECtKnIKK113zEFoMqWks5sedMqgaJpZM4OnPGV.

Kaffiend commented 6 years ago

i'll try to get to this either later this evening or tomorrow morning, Had some time sensitive issues crop up in some old COBOL apps that requires my attention for the better part of this weekend unfortunately.

colinskow commented 6 years ago

@Kaffiend thank you very much for your work on this. Using your changes as a guide I was able to work things out and get the build passing, even with store-freeze working. However I did a slightly different implementation so it was easier for me to copy and paste from your code than to try to rebase your fork.

I will be merging this feature in very shortly after some final polish.

Css-IanM commented 6 years ago

@colinskow That’s great news, I look forward to the update.

Ian Mackie Lead Developer Complete System Support, Inc.

From: Colin Skowmailto:notifications@github.com Sent: Monday, September 25, 2017 8:03 AM To: colinskow/angular-electron-dream-startermailto:angular-electron-dream-starter@noreply.github.com Cc: Ian Mackiemailto:ianm@completesystemsupport.com; Commentmailto:comment@noreply.github.com Subject: Re: [colinskow/angular-electron-dream-starter] Upgraded Deps and NGRX 4.x.x (#7)

@Kaffiendhttps://github.com/kaffiend thank you very much for your work on this. Using your changes as a guide I was able to work things out and get the build passing, even with store-freeze working. However I did a slightly different implementation so it was easier for me to copy and paste from your code than to try to rebase your fork.

I will be merging this feature in very shortly after some final polish.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/colinskow/angular-electron-dream-starter/pull/7#issuecomment-331859970, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AdUBQkb_v_a9w0d7vmqt-oo2QOovMyfOks5sl5Z9gaJpZM4OnPGV.

colinskow commented 6 years ago

DONE!