search

colinskow / ng-superlogin

AngularJS bindings for the SuperLogin project
MIT License
15 stars 17 forks source link

validateUsername()/validateEmail() now fail with $q.reject(err) #11

Closed tohagan closed 8 years ago

tohagan commented 8 years ago

validateUsername()/validateEmail() now return $q.reject(err) to allow a caller to test err.status when a reject occurs.

Once you've released this under a new version, can you then please update superlogin-demo with new version dependency? Then I can add the other fix to superlogin-demo and commit/test it against the right version. No rush :) .

tohagan commented 8 years ago

Just a reminder that this change is really a breaking change (but minor one) so probably needs a mention in version history just in case someone wrote code to use err.data that used to be returned.