Closed arielvalentin closed 7 years ago
LGTM. reviewing this I noticed I created the Loggable
module to try and DRY this up a bit but for some reason, this was never completed and Loggable
is unused.
If you feel like completing this that would be great, otherwise I'll merge this and we can create an issue to not forget to complete the Loggable
thing.
I will give it a shot
I replaced the usage with Loggable module. I didn't think to write additional tests for it. Is that something you would like?
good stuff, thanks. just curious per my inline comment why not use Loggable
in the Topology
class too?
Oops!! I'll fix that.
Thanks,
Sent from my mobile device. Please excuse any errors.
On Aug 7, 2014, at 10:45 AM, Colin Surprenant notifications@github.com wrote:
good stuff, thanks. just curious per my inline comment why not use Loggable in the Topology class too?
— Reply to this email directly or view it on GitHub.
Our attempt to address issues https://github.com/colinsurprenant/redstorm/issues/110 https://github.com/colinsurprenant/redstorm/issues/111