Use SLF4J loggers and add support for named hierarchies

colinsurprenant / redstorm

JRuby on Storm

Other

298 stars 56 forks source link

Use SLF4J loggers and add support for named hierarchies #115

Closed arielvalentin closed 7 years ago

arielvalentin commented 10 years ago

Our attempt to address issues https://github.com/colinsurprenant/redstorm/issues/110 https://github.com/colinsurprenant/redstorm/issues/111

colinsurprenant commented 10 years ago

LGTM. reviewing this I noticed I created the Loggable module to try and DRY this up a bit but for some reason, this was never completed and Loggable is unused.

If you feel like completing this that would be great, otherwise I'll merge this and we can create an issue to not forget to complete the Loggable thing.

arielvalentin commented 10 years ago

I will give it a shot

coveralls commented 10 years ago

Coverage increased (+0.03%) when pulling fde7148ee1dcb2581f4b5af74a2e0198a8943799 on arielvalentin:update-logging-110-111 into 3f711edc96d7769a73010e903cafc3647b44d7fe on colinsurprenant:master.

arielvalentin commented 10 years ago

I replaced the usage with Loggable module. I didn't think to write additional tests for it. Is that something you would like?

colinsurprenant commented 10 years ago

good stuff, thanks. just curious per my inline comment why not use Loggable in the Topology class too?

arielvalentin commented 10 years ago

Oops!! I'll fix that.

Thanks,

Ariel

Sent from my mobile device. Please excuse any errors.

On Aug 7, 2014, at 10:45 AM, Colin Surprenant notifications@github.com wrote:

good stuff, thanks. just curious per my inline comment why not use Loggable in the Topology class too?

— Reply to this email directly or view it on GitHub.

coveralls commented 10 years ago

Coverage increased (+0.11%) when pulling 02c79c9282b9ff014eab0222f465427268465b00 on arielvalentin:update-logging-110-111 into 3f711edc96d7769a73010e903cafc3647b44d7fe on colinsurprenant:master.