search

colinta / StrangeCase

It's yet another static site generator. Have you seen jekyll? hyde? Yup. Like those.
http://colinta.com/projects/StrangeCase.html
Other
49 stars 7 forks source link

Jinja-windows fix, just in JinjaNode #44

Closed edbrannin closed 11 years ago

edbrannin commented 12 years ago

Maybe only using os.path.relpath() in JinjaNode.render() won't break whatever test just broke for Colin?

(If it does break, which test is it?)

edbrannin commented 12 years ago

Hey, pull requests auto-update. That's nice.

(I'm way more familiar with mercurial, but haven't done much of this social coding there either)

colinta commented 12 years ago

No, it's the same errors (TemplateNotFound from Jinja). You should be able to run the tests by running installing py.test: pip install pytest and then running py.test.

colinta commented 12 years ago

I don't suppose you can hop over to IRC (irc.freenode.net / #strangecase)? I would like to chat through this...

edbrannin commented 12 years ago

I don't think I'll be able to hop on IRC during the day today, but I can try an evening/weekend/later-next-week.

I saw those test failures on my Mac at home last night, but interestingly those test failures didn't correspond to actual usage failures: I was still able to build a site with an index.j2 that extended a layouts/base.j2 template.

colinta commented 11 years ago

I've moved some files around, so this isn't easily merged. Closing, but if you ever get a chance to re-implement, it'd be nice to have better windows support.

edbrannin commented 11 years ago

um... where did you move this file to? It looks like strange_case/nodes/jinja.py has the same location & contents as when I made this patch. Did you forget to push something, or am I looking in the wrong branch?

colinta commented 11 years ago

I assumed I had moved it, because the automatic merge is disabled... but I don't have any changes to push.

edbrannin commented 11 years ago

I probably just fail at git. I use it so infrequently, and every time it's a task of moderate learning curve like a pull request.

Maybe I'll try this again through hg-git.

-Ed Brannin edbrannin@gmail.com cell: 585-261-0279