search

colinta / teacup

This project has been sunset in favor of MotionKit
github.com/motion-kit/motion-kit
Other
602 stars 85 forks source link

Remove a stray puts #129

Closed JonRowe closed 11 years ago

JonRowe commented 11 years ago

This floods my console when running tests so it seems like it was accidentally included?

colinta commented 11 years ago

No accident on this one; it is only run when it was not possible to find a superview or matching view... it's supposed to be a helpful debugging error. Instead of silencing it, I would wonder first why it is appearing when you run tests (it should not, I think)

JonRowe commented 11 years ago

Interestingly I've just noticed the raise below, that I never see in my output, but the puts was definitely being used with no ill effect. There was no other message so this output is not at all helpful, prehaps adding a message to the end saying what you think the problem is will make this more helpful.

colinta commented 11 years ago

I think the error message explains it, what is strange is that the exception is being caught, and not being displayed. But I'll add a message that explains the puts output anyway.

JonRowe commented 11 years ago

How about rolling this out put into the error message instead? That way when it's a legitimate error you get the feedback, but when it's raised and captured you don't. (e.g. in tests)