colinxfleming / simpsons_data

A Simpsons dataset, so that you can filter out clip show episodes
12 stars 6 forks source link

Adding season 33, new shorts data #67

Open marikodes opened 1 year ago

marikodes commented 1 year ago

I would like to help out by adding data for season 33, as well as the most recently released D+ shorts.

colinxfleming commented 1 year ago

hey @marikodes , thank you! I'd say let's point you toward the shorts first - I've been sticking those in episodes/season_theatrical.yml.

Below is a list of the fields and how to get em:

- title: Maggie Simpson in The Force Awakens from Its Nap # episode title
  season: 99 # I've been putting shorts in season 99
  episode: 5 # episode number
  release_date: # YYYY-MM-DD, can usually find this on wikipedia
  directors: # either credits of episode or wikipedia
  writers: # either credits of episode or wikipedia
  description: # get this from Disney+
  disneyplus_id: # the disney+ UUID
  simpsonsworld_id: # leave blank since simpsonsworld is gone
  good: # either true, false, or maybe
  guest_stars: # optional array of strings, can leave blank or [] if there aren't guest stars
colinxfleming commented 1 year ago

(let me know if you need a hand opening up a pull request on github, happy to help!)

marikodes commented 1 year ago

Yes please! I am new to pull requests, I did visit the Github docs but it isn't quite clicking. Should I fork this repo and then create a pull request from the forked version (also is that where I would put the data)?

colinxfleming commented 1 year ago

yep! roughly the steps (if I remember right) are: