search

colis-anr / morbig

A static parser for POSIX Shell
Other
190 stars 8 forks source link

Remove double quotation from parameter #122

Open ishaangandhi opened 3 years ago

ishaangandhi commented 3 years ago

Right now, an extra set of double quotes surrounds every parameter. This pull request fixes that.

Test plan:

$ make check
if command -v ocamlopt >/dev/null; then cp src/c/dune.native src/c/dune; fi
dune build @install
Done: 0/0 (jobs: 0)[ -e bin ] || ln -sf _build/install/default/bin bin
[ -e lib ] || ln -sf _build/install/default/lib/morbig lib
* Testsuite configuration
Using local ~/morbig/bin/morbig.
* Summary:
-----------------------------------
| Tests | Passed | Failed | Total |
|-------|--------|--------|-------|
| good  |    110 |      0 |   110 | 
| bad   |     67 |      0 |    67 |
| all   |    177 |      0 |   177 |
-----------------------------------

         ----------------
         Congratulations!
         ----------------
Niols commented 1 year ago

The tests suite in CI is currently unreadable. This should be fixed by #169 so maybe we should wait for that, rebase this on top of main and then see?

yurug commented 1 year ago

The tests suite in CI is currently unreadable. This should be fixed by #169 so maybe we should wait for that, rebase this on top of main and then see?

Yes, let's do that.

Niols commented 1 year ago

@yurug Called for a rebase using #169. Now the CI should give us much more readable outputs.