search

colis-anr / morbig

A static parser for POSIX Shell
Other
190 stars 8 forks source link

Fully rewrite the golden tests runner using Alcotest #169

Closed Niols closed 1 year ago

Niols commented 1 year ago

We use Alcotest.skip crucially, for which v1.7.0 at least is necessary. This will however make tests uninstallable on version of OCaml older than 4.10. I believe we should just drop support for those versions. Our reference is usually Debian stable which, currently, ships with OCaml 4.11.

Niols commented 1 year ago

Actually, Alcotest 1.7 compiles fine from OCaml 4.08 onwards. What blocked use was List.concat_map, so I got rid of this and removed official support for OCaml < 4.08. Note that, at this point, Morbig still compiles with older versions, but I don't think it makes much sense to check for that or limit ourselves for such old versions.

Niols commented 1 year ago

Waiting for #170. After that, I will be able to rebase and to use the newly introduced no-doc and no-tests flags in CI.