search

colis-anr / morbig

A static parser for POSIX Shell
Other
190 stars 8 forks source link

Improve Dockerfile and CI #48

Closed Niols closed 5 years ago

Niols commented 5 years ago

  1. Improve Dockerfile. It now uses ocaml/opam2 (ocaml/opam isn't maintained anymore anyway) and Morbig's local files (instead of cloning the GitHub repo).

  2. CI now uses Docker. It speeds things up a lot. It used to take ~8min per build, it now takes ~3. This is essentially because we don't have to install OPAM and compile OCaml (from scratch). This avoids encountering the stack overflows we currently have. The OSX build hasn't changed much as it cannot be done inside Docker.

  3. CI now pushes automatically the successful builds of the master branch (it is also very easy to add other branches) to DockerHub.

Niols commented 5 years ago

On Travis, using their secret storage thing. These are my usernames and password. Do you think I should document that in the .travis.yml? Or avoid using that at all?

-------- Message d’origine -------- De : "Yann Régis Gianas" notifications@github.com Envoyé : 6 septembre 2018 13:53:48 GMT+02:00 À : colis-anr/morbig morbig@noreply.github.com Cc : Nicolas Jeannerod niols@niols.fr, Author author@noreply.github.com Objet : Re: [colis-anr/morbig] Improve Dockerfile and CI (#48)

yurug commented on this pull request.

  • env: null
  • install:
    • brew install opam
    • opam init --no-setup
    • eval $(opam config env) && opam install --yes menhir yojson ppx_deriving_yojson visitors
  • script:
    • make
    • make install
    • make uninstall
    • make check

  • +## We automatically deploy sucessfull branch builds to DockerHub.

  • +before_deploy:

    • echo "$DOCKER_PASSWORD" | docker login --username "$DOCKER_USERNAME" --password-stdin

Where is set this variable?

yurug commented 5 years ago

No action required. It was just out of curiosity!