Cleanup Dune compilation

colis-anr / morbig

A static parser for POSIX Shell

Other

192 stars 8 forks source link

Cleanup Dune compilation #63

Closed Niols closed 5 years ago

Niols commented 5 years ago

This PR:

removes the workaround with ar.
renames the entry point of Morbig from Morbig.API to Morbig.
renames MorbigOptions into Options now that we have Dune to take care of overlapping names.
allows for customization of what is exported in the Morbig library (see morbig.ml)

fix #64

Niols commented 5 years ago

By the way, looking at all the module names in morbig.ml, I think that lots of them could be hidden. One just has to remove the corresponding like from that file. I'm not sure which ones should be deleted, but that could be nice. Don't hesitate to push to the dune-2 branch in that case.

Niols commented 5 years ago

Also, we have a lot of modules. Maybe we could/should reorganize them in subdirectories? (Or even in sub-libraries?)

yurug commented 5 years ago

A potential reorganization should be done in a distinct PR, IMHO.

Niols commented 5 years ago

Indeed, and maybe only after your bug merge. Actually, I should maybe postpone this PR and wait for yours?

Le 20 février 2019 12:28:06 GMT+01:00, "Yann Régis Gianas" notifications@github.com a écrit :

A potential reorganization should be done in a distinct PR, IMHO.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/colis-anr/morbig/pull/63#issuecomment-465536400