Closed sweep-ai[bot] closed 4 months ago
This is an automated message generated by Sweep AI.
Re check the changes to dont remove the returnCallback in this PR. Just deprecate it. Also, we need to update the tests cases in the src/index.test.ts file to validate we are deprecating the support for callbacks.
Description
This pull request introduces a significant shift in the
bitpay-rates
library by deprecating callback support in favor of promises for the.get
method. This change aligns with modern JavaScript practices, promoting more readable and maintainable code. It also includes updates to documentation and examples to guide users towards the new promise-based approach.Summary
.get
method across the library. Users are encouraged to use promises instead.https
import insrc/index.ts
as it's no longer needed for the new implementation.README.md
andexample/rates-example.js
to reflect the shift to promises, removing examples of the deprecated callback usage.src/index.ts
to remove the callback-related functions and streamline the promise implementation.Fixes #255.
💡 To get Sweep to edit this pull request, you can:
This is an automated message generated by Sweep AI.