colkito / bitpay-rates

BitPay Exchange Rates API wrapper for Node.js - A tiny and easy to use library
https://npmjs.com/bitpay-rates
4 stars 2 forks source link

Sweep: Deprecate the callback support in the `.get` method. #256

Closed sweep-ai[bot] closed 4 months ago

sweep-ai[bot] commented 4 months ago

Description

This pull request introduces a significant shift in the bitpay-rates library by deprecating callback support in favor of promises for the .get method. This change aligns with modern JavaScript practices, promoting more readable and maintainable code. It also includes updates to documentation and examples to guide users towards the new promise-based approach.

Summary

Fixes #255.


💡 To get Sweep to edit this pull request, you can:

This is an automated message generated by Sweep AI.

sweep-ai[bot] commented 4 months ago

Rollback Files For Sweep

This is an automated message generated by Sweep AI.

colkito commented 4 months ago

Re check the changes to dont remove the returnCallback in this PR. Just deprecate it. Also, we need to update the tests cases in the src/index.test.ts file to validate we are deprecating the support for callbacks.