collab-community / journey-book

Folks are welcome to share about themselves, even a little introduction is appreciated.
https://collab-community.github.io/journey-book/
MIT License
50 stars 77 forks source link

Formalizing Data.json with fewer parameters #179

Open ashishk1331 opened 2 years ago

ashishk1331 commented 2 years ago

Is your feature request related to a problem? Please describe. In Data.json file, each user data is structured as

{
    "name": "Arpit Ghura", 
    "username": "arpitghura",
    "avatar": "https://github.com/arpitghura.png"
},

The avatar_url only requires the username as the filling parameter. The URL can be constructed using username only like,

   url = https://github.com/${ username }.png

Describe the solution you'd like I would like to change the data schema to

{
     "name": "Arpit Ghura",
     "username": "arpitghura"
 }

This would reduce the code size and create fewer errors while adding details. Also, a custom script to update the initial dataJSON file to adhere to the new data schema. As well, adapt the serving code to process the avatar image using username only.

Describe alternatives you've considered Leave the code as it is. As it works fine!

Additional context I can help develop this feature. I do have a good knowledge of python (which I can use for that script) and I also know javascript, being a JAM-stack developer. Or I can only use Javascript to process all. Plus, I'm good at chores such as data manipulation.

github-actions[bot] commented 2 years ago

Thank you for contributing to Journey Book. We love you and your Issue ❤️🎉 . Your issues, really help us with our project... Waiting for you to contribute again to Journey Book.

UlbertAO commented 2 years ago

I would like to work on this