collab-community / journey-book

Folks are welcome to share about themselves, even a little introduction is appreciated.
https://collab-community.github.io/journey-book/
MIT License
50 stars 77 forks source link

Formalizing Data.json with fewer parameters #179 #184

Closed UlbertAO closed 1 month ago

UlbertAO commented 2 years ago

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # 179

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

Checklist:

piece of code for Data.json

const fs=require("fs");
let d;
d=JSON.parse(fs.readFileSync("Data.json",'utf8'));
d=d.map(({name,username})=>({name,username}));
fs.writeFileSync("Data.json",JSON.stringify(d))
vikasganiga05 commented 2 years ago

Hi @UlbertAO , Thanks for contributing. But we added the avatar property for those who don't have github profile picture or the user want to use another profile picture as a avatar. This will break flow of the projects. What are your thoughts on this @Adarsh-jaiss ?

UlbertAO commented 2 years ago

Hi @vikasganiga05 , @Adarsh-jaiss If that is the case then can we do it like this -if people want their avatar to be same as github profile avatar then they need to specify name and username only -if people want some custom avatar then can add avatar url as well

NOTE: if avatar is not specified in data.json git hub profile avatar will be picked