search

collab-project / videojs-wavesurfer

video.js plugin that adds a navigable waveform for audio and video files
https://collab-project.github.io/videojs-wavesurfer
MIT License
365 stars 54 forks source link

Fullscreen mode does not work with wavesurfer plugins #164

Open Aleksandar-G opened 2 years ago

Aleksandar-G commented 2 years ago

Description

Fullscreen mode does not work with wavesurfer plugins

Steps to reproduce

https://codesandbox.io/s/funny-rain-4hiqup

Here I have created a demo to show the bug. You can open the project. Open the browser window on a new tab to enable the fullscreen button and make the video fullscreen and play it. After you have played it you will see that the regions are deleted and a error pops on the screen.

Results

Expected

The fullscreen mode to work and not to crash the application

Actual

After you enter a fullscreen mode and play the video the plugins stop working and a type error is thrown

Error output

Uncaught TypeError: Cannot read properties of null (reading 'scrollWidth')
    at TimelinePlugin.updateCanvases

Versions

Make sure to include the following versions:

videojs/wavesurfer

what version of video.js, videojs-wavesurfer and wavesurfer.js does this occur with? video.js - 7.20.3 wavesurfer.js - 6.3.0 videojs-wavesurfer - 3.9.0

Browsers

what browser(s) are affected? Make sure to test with all third-party browser extensions disabled. Google Chrome Version 105.0.5195.125

OSes

what platforms (operating systems and devices) are affected? Linux Ubuntu