collab-uniba / econference-planning-poker-plugin

Automatically exported from code.google.com/p/econference-planning-poker-plugin
0 stars 0 forks source link

Many errors and warnings in the PlanningPoker plugin.xml #46

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
There are many warnings and errors in the plugin.xml file.
See the xml directly and fix all the warnings.
Many refers to the fact that we have refactored the multichat package into m2m. 
So in this case, it's a quick fix.
However, I'm concerned with the fact that many warnings relate to the 
PlanningPoker perspective extension point 
(see <extension point="org.eclipse.ui.perspectiveExtensions">).

Original issue reported on code.google.com by calefato.uniba@gmail.com on 26 Nov 2010 at 3:21

GoogleCodeExporter commented 9 years ago

Original comment by papa...@gmail.com on 26 Nov 2010 at 4:34

GoogleCodeExporter commented 9 years ago
The warning related to the planning poker perspective was due to a wrong 
perspective ID. 
"it.uniba.di.cdg.econference.planningpoker.PlanningPokerPerspective" instead of 
"it.uniba.di.cdg.econference.planningpoker.PPPerspective" as declared in the 
perspective class.

Original comment by papa...@gmail.com on 26 Nov 2010 at 4:36

GoogleCodeExporter commented 9 years ago
Have you properly tested that the perspective works fine and as expected after 
this fix? 

Is the code recently added for preventing the views to close still needed? 
Plugin.xml has properties set to closeable="false" for PPPerspective views.

Also, do we really have a view named StoriesListView? And how come there at the 
same time references to 
it.uniba.di.cdg.econference.planningpoker.views.StoriesListView and 
it.uniba.di.cdg.econference.planningpoker.ui.workbench.StoriesListView?

Original comment by calefato.uniba@gmail.com on 26 Nov 2010 at 5:27

GoogleCodeExporter commented 9 years ago
1. I've tested it, and it works but now messages like "Part already exists in 
page layout: it.uniba.di.cdg.econference.planningpoker.EstimatesView." are 
printed in the console log when the planning poker perspective is opened. Maybe 
we don't need to programmatically add views to the perspective if we already 
added them in the plugin.xml?

2. The code added for preventing the views to close is no more needed. I 
deleted it.

3. it.uniba.di.cdg.econference.planningpoker.views.StoriesListView is the view 
id of the backlog. I couldn't find any reference to 
it.uniba.di.cdg.econference.planningpoker.ui.workbench.StoriesListView in 
plugin.xml

Original comment by papa...@gmail.com on 26 Nov 2010 at 6:27

GoogleCodeExporter commented 9 years ago
1. might be. please this is a simple but very important task. see what's 
better. adding views programmatically or via xml. check on vogella, maybe. 
remove one of the two. for the time being, I reset it to "started" status.

2. thanks

3. yep, may I was looking at the older version. mow seems to be fine!

Original comment by calefato.uniba@gmail.com on 26 Nov 2010 at 7:27

GoogleCodeExporter commented 9 years ago
I found this on vogella.de

    "I personally prefer extension points over code. But instead of using the extension point "org.eclipse.ui.perspectiveExtensions" you could also add the view via code to the perspective"

Original comment by papa...@gmail.com on 27 Nov 2010 at 10:05

GoogleCodeExporter commented 9 years ago

Original comment by papa...@gmail.com on 29 Nov 2010 at 8:29