search

collectionspace / cspace-config-untangler

Generate CollectionSpace data overviews from profile/tenant configs
MIT License
0 stars 4 forks source link

write profile version to mapper config #72

Closed kspurgin closed 3 years ago

kspurgin commented 3 years ago

This will ensure mapper uniqueness across releases, even if the data model does not actually change for a given profile/recordtype.

This is necessary because collectionspace-batch-importer uses a digest hash based on the content of the mapper to identify when a mapper has changed and needs to be re-downloaded. Two mappers cannot have the same digest hash in collectionspace-batch-importer, so if it is going to support multiple CollectionSpace releases, we need to guard against duplicate mappers with duplicate digests.

Adding version to the mapper itself is a quick way to do this, and may have other affordances.

kspurgin commented 3 years ago

Ok, well that was an easy change since I already made it and forgot

I will take this opportunity to update the 6.0 and 5.2 release mappers so they get profile and version written.

kspurgin commented 3 years ago

Nope. 6.0 has so many invalid mappers due to things being handled inconsistently in the writing of the JSON configs. I know that 5.2 is even worse. There is no clear reason to go back and do a bunch of work on pre 6.1 to make them work. I will keep the JSON configs around for reference, but delete the mappers, templates, manifests, etc.