search

collective / Collective

Plone Collective Requests, Questions, Maintenance
http://collective.github.io
123 stars 164 forks source link

Need help to configure variable settings on collective.contentrules.mailtogroup #1825

Closed 1letter closed 8 months ago

1letter commented 9 months ago

@collective/staff Is it possible to set Variables in a collective package? I can't do this as Member. In my own Repros i can set Variables.

I need two Variables:

TEST_OS_VERSIONS ["ubuntu-22.04", "ubuntu-20.04"]

TEST_PYTHON_VERSIONS ["3.8","3.9","3.10","3.11"]

tkimnguyen commented 9 months ago

Saw this but don't know the answer. It might be a good idea to ask in the forum.

MrTango commented 9 months ago

are you not using GitHub actions? There you normally set all the Python and Plone versions directly.

MrTango commented 9 months ago

I just checked the repo, it is not using GH actions, that should be changed. Most repos here are using it already and we also have the Plone/Meta configuration which can be used by addons.

1letter commented 9 months ago

@MrTango

I just checked the repo, it is not using GH actions, that should be changed. Most repos here are using it already and we also have the Plone/Meta configuration which can be used by addons.

I have setup the GHA in this PR https://github.com/collective/collective.contentrules.mailtogroup/pull/32

fredvd commented 9 months ago

@1letter The variables (and secrets) you can set on the repository or environment level are only useful if you want to share them over many workflow files or share them on the organisation level. To have a test matrix with python/plone versions you can define these in the workflow file themself, there's no obligation to user repository variables/secrets.

I hope this answers the question and I'll close the issue. If you have any other question or issues with the variables, please re-open.

1letter commented 9 months ago

@fredvd i understand. but plone/meta provided a workflow file https://github.com/plone/meta/blob/main/.github/workflows/test.yml and this workflow ist included if a project setup via plone/meta. I can copy and customize this file. but, from my point of view, this is not needed, because it can be configured via variables. If the checks only for python3.11 ok, then i will use this blueprint file without customizations.

gforcada commented 9 months ago

We should provide fallback values: https://github.com/plone/meta/issues/190