search

collective / Products.EasyNewsletter

Powerful newsletter/mailing product for Plone.
https://pythonhosted.org/Products.EasyNewsletter/
GNU General Public License v2.0
28 stars 23 forks source link

Improper saluation handling for test send #134

Open zopyx opened 5 years ago

zopyx commented 5 years ago

The salutation handling code is broken for test send:

https://github.com/collective/Products.EasyNewsletter/blob/master/Products/EasyNewsletter/content/ENLIssue.py#L378-L389


(Pdb) salutation_mappings
{'ms': {'de': 'Sehr geehrte Damen und Herren,'}, 'mr': {'de': 'Sehr geehrte Damen und Herren,'}}

(Pdb) salutation = salutation_mappings.get('default', '')
(Pdb) salutation
''
(Pdb) salutation.get(self.Language(), '')
*** AttributeError: 'str' object has no attribute 'get'
zopyx commented 5 years ago

The same issue is true for the real send operation.