search

collective / Products.EasyNewsletter

Powerful newsletter/mailing product for Plone.
https://pythonhosted.org/Products.EasyNewsletter/
GNU General Public License v2.0
28 stars 23 forks source link

Plone 6 compatibility #177

Closed petschki closed 2 years ago

petschki commented 2 years ago

remove <includeDependencies /> and Plone < 5 support

codecov-commenter commented 2 years ago

Codecov Report

Merging #177 (f7058c4) into master (ea69ebf) will increase coverage by 0.23%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #177      +/-   ##
==========================================
+ Coverage   86.01%   86.25%   +0.23%     
==========================================
  Files          91       91              
  Lines        3497     3491       -6     
==========================================
+ Hits         3008     3011       +3     
+ Misses        489      480       -9
Impacted Files Coverage Δ
src/Products/EasyNewsletter/config.py 100.00% <ø> (ø)
src/Products/EasyNewsletter/utils/enl.py 70.00% <ø> (ø)
src/Products/EasyNewsletter/browser/issue.py 37.31% <100.00%> (-1.82%) :arrow_down:
src/Products/EasyNewsletter/portlets/subscriber.py 68.57% <100.00%> (+1.03%) :arrow_up:
...Products/EasyNewsletter/tests/test_registration.py 99.20% <100.00%> (+0.03%) :arrow_up:
src/Products/EasyNewsletter/tests/test_setup.py 100.00% <100.00%> (ø)
...ucts/EasyNewsletter/tests/test_unsubscribe_form.py 100.00% <100.00%> (ø)
src/Products/EasyNewsletter/tests/test_utils.py 100.00% <100.00%> (+12.00%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ea69ebf...f7058c4. Read the comment docs.

MrTango commented 2 years ago

sorry, i missed your PR but fixed this some days ago while working on the Newsletter.

MrTango commented 2 years ago

I'll fix the issue with the test setup soon and merge the changes, because you did some stuff i didn't cover yet.