search

collective / Products.PloneKeywordManager

Change, merge and delete keywords (AKA tags or subjects) in Plone.
https://pypi.org/project/Products.PloneKeywordManager/
4 stars 8 forks source link

Discussion update #11

Closed cekk closed 10 years ago

cekk commented 10 years ago

Hi, i've found that discussions inherit parent's subjects, but "getSetter" method of our tool doesn't handle discussions correctly. This cause that a deleted keyword stay in the catalog if one Discussion Item has that keyword

hvelarde commented 10 years ago

please don't merge this until I fix the CI... maybe tomorrow...

hvelarde commented 10 years ago

could you please update your pull request?

coveralls commented 10 years ago

Coverage Status

Changes Unknown when pulling 05fdc6d9419b96474a3e217fb5b19d34566d8dac on RedTurtle:discussion-update into \ on collective:master**.

cekk commented 10 years ago

Rebased with the updated master.

I had to fix some tests because locally were ok but on travis not. Now it seems to be all ok

hvelarde commented 10 years ago

thank you for fixing those! :beers:

cekk commented 10 years ago

it was a pleasure, i learned new things!