search

collective / Products.PloneKeywordManager

Change, merge and delete keywords (AKA tags or subjects) in Plone.
https://pypi.org/project/Products.PloneKeywordManager/
4 stars 8 forks source link

Plone5 compat #18

Closed cewing closed 8 years ago

cewing commented 8 years ago

This PR adds plone 5 compatibility (and fixes a few small issues in the page templates around this).

cewing commented 8 years ago

@hvelarde, I've fixed using plone.api for version detection both in test setup and also now in showing proper search icons for keywords in Plone 4 and in Plone 5.

I also lifted the accessibility work performed by @daniele-andreotti on PR #13, so if we merge this PR we can close that one as the work there is included here too.

Let's merge this and do a release so we've got one more Plone 5 compatible add-on out there.

hvelarde commented 8 years ago

@cewing do you mind to squash the whole thing into one commit? besides that, tests for Plone 4.2 are passing and we don't want to have them marked as an allowed failure in Travis.

jensens commented 8 years ago

Dont let code get old in PRs. This one is a huge step forward. I merge.

cewing commented 8 years ago

shoot. Somehow I missed your request above, @hvelarde. Thanks very much to @jensens for merging anyway. I appreciate it.