As of now, just installing Products.PloneKeywordManager in a plone 4.3.9 instance we have two Keyword Fields: "Subject" and "commentators".
The way the logic is made right now with the tool it's using an IGNORE_INDEXES, so "commentators" should be added to it as well since it's not exactly a keyword we're going to edit or merge on a particular website.
So, if in a future version of Plone another index is added, this constant will need to be upgraded again.
We were thinking, wouldn't it be a better approach to have an AVAILABLE_INDEXES that would have only Subject - and if an specific policy would like to use this plugin to manage other KeywordIndexes, you could just patch it, instead of the implementation we have today? The real bonus would be to change this constant to a registry.xml configuration so tou don't even need a patch :)
As of now, just installing Products.PloneKeywordManager in a plone 4.3.9 instance we have two Keyword Fields: "Subject" and "commentators".
The way the logic is made right now with the tool it's using an IGNORE_INDEXES, so "commentators" should be added to it as well since it's not exactly a keyword we're going to edit or merge on a particular website.
So, if in a future version of Plone another index is added, this constant will need to be upgraded again.
We were thinking, wouldn't it be a better approach to have an AVAILABLE_INDEXES that would have only
Subject- and if an specific policy would like to use this plugin to manage other KeywordIndexes, you could just patch it, instead of the implementation we have today? The real bonus would be to change this constant to a registry.xml configuration so tou don't even need a patch :)