The goal is to make the form respond better when the list of keywords is enormous.
I have added PloneBatch to the list of keywords
I have added livesearch to the "Keyword Search" form.
Opinions:
I removed the "select range" form - that functionality is really handled by batching now.
I removed the checks to show / hide the filtering forms based on the number of keywords:
I see this as 'magic UI' I'd rather move the filtering forms to somewhere less invasive then hide them based on a variable that's out of the user's control. Imaging adding just 'one more keyword' and suddenly your user experience changes?
I also removed all calls directly to the KeywordManager Tool from the template. The view gets a hold of the Tool and the template talks to the view. Best Practice.
I renamed some variables in the template (specifically 'subject' / 'subjects' to 'keyword' / 'keywords') I think 'subject / subjects' is an old name for when the form was developed with only the 'subjects' field in mind. Now that you can select which field to work on, the more generic 'keyword' should be used as a variable name.
This is big and I need some eyes.
This PR goes into a new branch - "flipmcf/issue 17" It's not ready for master yet. So approval should be easy.
https://github.com/collective/Products.PloneKeywordManager/issues/17
The goal is to make the form respond better when the list of keywords is enormous.
Opinions: I removed the "select range" form - that functionality is really handled by batching now. I removed the checks to show / hide the filtering forms based on the number of keywords: I see this as 'magic UI' I'd rather move the filtering forms to somewhere less invasive then hide them based on a variable that's out of the user's control. Imaging adding just 'one more keyword' and suddenly your user experience changes?
I also removed all calls directly to the KeywordManager Tool from the template. The view gets a hold of the Tool and the template talks to the view. Best Practice.
I renamed some variables in the template (specifically 'subject' / 'subjects' to 'keyword' / 'keywords') I think 'subject / subjects' is an old name for when the form was developed with only the 'subjects' field in mind. Now that you can select which field to work on, the more generic 'keyword' should be used as a variable name.