collective / Products.PloneKeywordManager

Change, merge and delete keywords (AKA tags or subjects) in Plone.
https://pypi.org/project/Products.PloneKeywordManager/
4 stars 8 forks source link

Version 5.0.0 target #80

Closed petschki closed 1 year ago

petschki commented 1 year ago

I'm updating the management template to Plone 6 and Bootstrap 5 ... would it be OK if version 5,0 targets Plone 6 only or should there be Plone 5.2 compatibility too ...

/cc @gforcada @jensens

jensens commented 1 year ago

cc @flipmcf

For my projects it would be fine, I pinned them to current release already and would love to see this moving further forward.

gforcada commented 1 year ago

I would probably want to add a few features to it at some point and we are still on Plone 5.2, but we can push it upstream to be 6.0 compatible and backport it to our fork, if we still are on 5.2 😄

petschki commented 1 year ago

As mentioned here https://github.com/collective/Products.PloneKeywordManager/pull/81#issuecomment-1326010958 I've created a 5.x branch before merging the plone6 changes. Does someone of you want to make a 6.0.0 release or give me an invite on pypi?

jensens commented 1 year ago

As mentioned here #81 (comment) I've created a 5.x branch before merging the plone6 changes. Does someone of you want to make a 6.0.0 release or give me an invite on pypi?

Invite sent!

petschki commented 1 year ago

@jensens sorry missed the invitation ... can u please send again?

flipmcf commented 1 year ago

We';re still on 5.2 also. Are there 5.2 breaking features coming in?

The core functionality for PKM shouldn't change bettwen 5.2 and 6.0 - so maybe what we need is this (Products.PloneKeywordManager) to provide a restAPI endpoint that a volto add-on can use?

But then, I'm just confused where the user will interact from - Volto or Plone Classic Backend?

I want to see this package carried into Plone 6 - but maybe we can just add Bootstrap and other dependencies to the setup.py so that a 5.2 install would just pull down a few more python packages and 'bootstrap' a 5.2 up to what it needs to make the new UX work well. Can we manage all the dependencies with pip or mxdev?

jensens commented 1 year ago

We';re still on 5.2 also. Are there 5.2 breaking features coming in?

The core functionality for PKM shouldn't change bettwen 5.2 and 6.0 - so maybe what we need is this (Products.PloneKeywordManager) to provide a restAPI endpoint that a volto add-on can use?

But then, I'm just confused where the user will interact from - Volto or Plone Classic Backend?

I want to see this package carried into Plone 6 - but maybe we can just add Bootstrap and other dependencies to the setup.py so that a 5.2 install would just pull down a few more python packages and 'bootstrap' a 5.2 up to what it needs to make the new UX work well. Can we manage all the dependencies with pip or mxdev?

I would keep it on a separate branch. I think backports are a better way to deal with bringing in features and bugfixes in the 4.x branch.

petschki commented 1 year ago

Released 6.0.0 which is for Plone 6+ only. Version 5.0.0 is on branch 5.x now.