Update interfaces.py - Githubissues

i-zone commented 10 years ago

Please remove restriction on 'is_default_page', so that all content could be aliased.

jaroel commented 10 years ago

Could you specify the expected behaviour (ie, children in Folders, should adding items to an alias be possible, etc) and add some tests?

A quick manual test shows that when I alias a Folder:

aliased-object/view works, without /view Exception
Children added to the source folder do not appear in the aliased folder.

lentinj commented 9 years ago

So the behaviour I see (which I'm guessing is what i-zone is trying to fix) is:-

Go to your site root, "Add new", "Alias"
Hit browse on the contenttree widget, you see nothing, or the default page for your site root if you have one (since is_default_page is True there). ...at this point I would like to search through my site and find some content to alias.

This is definitely similar to https://dev.plone.org/ticket/12290 - there plone.app.multilingual is also seemingly looking for content where is_default_page is True or False (whatever the meaning of that is). The code in question there has been ripped out:-

https://github.com/plone/plone.app.multilingual/commit/a322a12f9b6ad35c854f745307df1780d354b88a

Unfortunately the git history for collective.alias doesn't give many clues as to what the search restriction is trying to do.

TL;DR: +1 for merging this.

jaroel commented 9 years ago

Sorry, forgot I had this lying around!

collective / collective.alias

Update interfaces.py #2