collective / collective.contact.core

part of the collective.contact.* suite that provides a directory where you create persons, organizations, sub-organizations and positions
https://github.com/collective/collective.contact.demo
6 stars 10 forks source link

Make it easy to override the way sub organizations are displayed on an organization by calling a @@suborganizations view #56

Closed gbastien closed 6 years ago

gbastien commented 6 years ago

Hi @vincentfretin @sgeulette

I need to override the way sub organizations are displayed on an organization, and I prefer not override the entire organization.pt

I just replaced moved this part to a separated view "@@suborganizations" that is called in the organization view. By default rendering is same as before.

Thank you for reviewing and merging ;-)

Gauthier

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.09%) to 70.073% when pulling 2b95c06acbf3448ebaaec9aa20be809283d95824 on suborgs-rendering-easy-override into 3187c21064e8c302d0dc15d46827a4e3d9f203a0 on master.

gbastien commented 6 years ago

Hi @vincentfretin

I do know if you received github review notification?

Can you review this? It does not change anything by default but make it easy to override.

Thank you!

Gauthier

vincentfretin commented 6 years ago

Hi @gbastien, yes I received it, but didn't took the time to look at it. If nobody else review it, merge it, same for the other PR pending. Really do whatever you want with this package, you can be one of the maintainers. I use it only on one project and I'll never upgrade it.