search

collective / collective.contact.core

part of the collective.contact.* suite that provides a directory where you create persons, organizations, sub-organizations and positions
https://github.com/collective/collective.contact.demo
6 stars 10 forks source link

Add support for Python 3 #62

Open vernans opened 5 years ago

vernans commented 5 years ago

I'm working on that on PLOG.

vernans commented 5 years ago

@agitator What's up with the plone5 and the plone5degrok branches? Were they just not finished, have there been any problems?

agitator commented 5 years ago

plone5degrok was an intermediate branch and can be deleted. plone5 is what I'm using for a client site with 5.1.5 @tdesvenain imho rebased plone5 with master, best thing would be to ask him ;-)

agitator commented 4 years ago

I started working on this in https://github.com/collective/collective.contact.core/tree/plone5-only

@vernans any idea on https://github.com/collective/collective.contact.core/issues/61 ?

agitator commented 4 years ago

Removed all grok remains in plone5-only ...

c.contact.widget would be next to degrok but as I got a better in depth view of the whole addon, I'd rather switch to z3c.relationfield/RelationChoice/RelationList with pat-relateditems than to upgrade and maintain the existing widget package.

UI and functionalitywise I don't see anything missing... and will try it out in the coming week.

An upgrade step would be necessary to migrate existing field values which would be also on my list.

I think that would be the most future proof way to do it.

agitator commented 4 years ago

Looked into using z3c.relationfield but gave up when I saw the to me weird seeming interface dependencies between core and widget, especially IContactContent... still think it would make sense.

Meanwhile started further upgrading/degroking the widget in https://github.com/collective/collective.contact.widget/blob/plone5-mockup-degrok

agitator commented 4 years ago

https://github.com/collective/collective.contact.core/tree/plone5-only seems to work on py3 now also added py3 branches for plone.formwidget.masterselect and plone.formwidget.contenttree

robot is still haunting me an I'll probably give up on that - python test are green but will continue with manual testing

agitator commented 3 years ago

@sgeulette @gbastien any update on your plans towards Plone5/6 and a 2.0 version?

sgeulette commented 3 years ago

Hi @agitator , we plan to start working on Plone5 migration at the end of the year.